[SPARK-58934][BUILD] Tolerate apt-get remove failures directly - #58206
Closed
nchammas wants to merge 2 commits into
Closed
[SPARK-58934][BUILD] Tolerate apt-get remove failures directly#58206nchammas wants to merge 2 commits into
nchammas wants to merge 2 commits into
Conversation
uros-b
approved these changes
Aug 21, 2026
Member
|
Thank you @nchammas! |
HyukjinKwon
approved these changes
Aug 24, 2026
zhengruifeng
approved these changes
Aug 24, 2026
nchammas
added a commit
that referenced
this pull request
Aug 25, 2026
### What changes were proposed in this pull request? Tolerate failures from `apt-get` remove directly. Refactor the list of packages to remove into an array. Remove the call to `apt-get update`. ### Why are the changes needed? #53226 added the call to `update` specifically to fix intermittent failures when calling `remove`. That `update`, however, had its own issues and hit up against actions/runner-images#14594. This in turn triggered the addition of a timeout to the cleanup in #58121. If we tolerate `remove` failures directly, we don't need the `update` anymore. I don't think we need the timeout either, but I've left that alone. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI on this PR. ### Was this patch authored or co-authored using generative AI tooling? I wrote this with assistance from GitHub Copilot. Closes #58206 from nchammas/free-disk-space-cleanup. Authored-by: Nicholas Chammas <nicholas.chammas@gmail.com> Signed-off-by: Nicholas Chammas <nicholas.chammas@gmail.com> (cherry picked from commit 6f89924) Signed-off-by: Nicholas Chammas <nicholas.chammas@gmail.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Tolerate failures from
apt-getremove directly. Refactor the list of packages to remove into an array. Remove the call toapt-get update.Why are the changes needed?
#53226 added the call to
updatespecifically to fix intermittent failures when callingremove.That
update, however, had its own issues and hit up against actions/runner-images#14594. This in turn triggered the addition of a timeout to the cleanup in #58121.If we tolerate
removefailures directly, we don't need theupdateanymore. I don't think we need the timeout either, but I've left that alone.Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI on this PR.
Was this patch authored or co-authored using generative AI tooling?
I wrote this with assistance from GitHub Copilot.